Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ohm - open hardware manager (as to be used on OLPC) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246748 ------- Additional Comments From mclasen@xxxxxxxxxx 2007-07-05 14:15 EST ------- - Please use a full source url - You probably need some requires(post) (pre), etc for ldconfig, useradd, etc - I don't think it is a good idea to use / as the homedir, the wiki says: should usually be a directory created and owned by the package, with appropriately restrictive permissions. One good choice for the location of the directory is the package's data directory in case it has one. - have you requested an official user id for ohm ? - please don't mix %{buildroot} and $RPM_BUILD_ROOT in one .spec file - %dir %{_sysconfdir}/dbus-1/system.d should certainly be owned by dbus, no ? - are libohm.so.* shared libs or modules ? if they are dlopened, they should better live in /usr/lib/ohm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review