https://bugzilla.redhat.com/show_bug.cgi?id=1361320 --- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Fix "%{name}%{_isa} = %{version}-%{release}" of -devel package. - -doc is a noarch package; its dependencies must not be arched: %package doc Summary: API documentation for cAudio Requires: %{name}%{_isa} = %{version}-%{release} <--- BuildArch: noarch - These lines are unnucessary # Install the documentation mkdir -p %{buildroot}%{_docdir}/%{name}/ cp -a ../README.md %{buildroot}%{_docdir}/%{name}/ cp -ra ../Documentation/html %{buildroot}%{_docdir}/%{name}/ You can just use %doc Documentation/html README.md - There are a lot of errors for missing /dot command: sh: dot: command not found error: Problems running dot: exit code=127, command='dot', arguments='"/builddir/build/BUILD/cAudio-2.2.0/Documentation/html/d1/dfd/namespacec_audio_a8f5f0f443431e8372a8e32ed39e80071_icgraph.dot" -Tpng -o "/builddir/build/BUILD/cAudio-2.2.0/Documentation/html/d1/dfd/namespacec_audio_a8f5f0f443431e8372a8e32ed39e80071_icgraph.png"' Does this package need 'graphviz' package for compiling the html documentation? - Fix all unused-direct-shlib-dependency warnings (see rpmlint output. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated", "zlib/libpng". 186 files have unknown license. Detailed output of licensecheck in /home/sagitter/1361320-cAudio/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/cAudio [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/cAudio [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cAudio- debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cAudio-2.2.0-2.fc26.x86_64.rpm cAudio-examples-2.2.0-2.fc26.x86_64.rpm cAudio-devel-2.2.0-2.fc26.x86_64.rpm cAudio-doc-2.2.0-2.fc26.noarch.rpm cAudio-debuginfo-2.2.0-2.fc26.x86_64.rpm cAudio-2.2.0-2.fc26.src.rpm cAudio-examples.x86_64: W: no-documentation cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial3_MemoryPlayback cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial5_AudioEffects cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial7_CustomLogReceiver cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial6_CustomEventHandler cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial1_2DSound cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial4_AudioCapture cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial1_3DSound cAudio-devel.x86_64: W: only-non-binary-in-usr-lib cAudio-devel.x86_64: W: no-documentation cAudio-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen 6 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: cAudio-debuginfo-2.2.0-2.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- cAudio-doc.noarch: W: spelling-error %description -l en_US doxygen -> oxygen, d oxygen cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libcAudio.so.0.1 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libogg.so.0 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libvorbisfile.so.3 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libvorbis.so.0 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libopenal.so.1 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libm.so.6 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libEAXLegacyPreset.so.0.1 /lib64/libgcc_s.so.1 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcAudio.so.0.1 /lib64/libogg.so.0 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcAudio.so.0.1 /lib64/libvorbis.so.0 cAudio.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcAudio.so.0.1 /lib64/libm.so.6 cAudio-examples.x86_64: W: no-documentation cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial3_MemoryPlayback cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial5_AudioEffects cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial1_2DSound cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial4_AudioCapture cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial7_CustomLogReceiver cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial1_3DSound cAudio-examples.x86_64: W: no-manual-page-for-binary Tutorial6_CustomEventHandler cAudio-devel.x86_64: W: only-non-binary-in-usr-lib cAudio-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 21 warnings. Requires -------- cAudio-doc (rpmlib, GLIBC filtered): cAudio(x86-64) cAudio (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcAudio.so.0.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libogg.so.0()(64bit) libopenal.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvorbis.so.0()(64bit) libvorbisfile.so.3()(64bit) rtld(GNU_HASH) cAudio-examples (rpmlib, GLIBC filtered): cAudio(x86-64) libc.so.6()(64bit) libcAudio.so.0.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libogg.so.0()(64bit) libopenal.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvorbis.so.0()(64bit) libvorbisfile.so.3()(64bit) rtld(GNU_HASH) cAudio-devel (rpmlib, GLIBC filtered): cAudio(x86-64) libEAXLegacyPreset.so.0.1()(64bit) libcAudio.so.0.1()(64bit) cAudio-debuginfo (rpmlib, GLIBC filtered): Provides -------- cAudio-doc: cAudio-doc cAudio: cAudio cAudio(x86-64) libEAXLegacyPreset.so.0.1()(64bit) libcAudio.so.0.1()(64bit) cAudio-examples: cAudio-examples cAudio-examples(x86-64) cAudio-devel: cAudio-devel cAudio-devel(x86-64) cAudio-debuginfo: cAudio-debuginfo cAudio-debuginfo(x86-64) Source checksums ---------------- https://raw.githubusercontent.com/liballeg/allegro5/master/cmake/FindVorbis.cmake : CHECKSUM(SHA256) this package : 23da0b9d120b27a0cc9b6b79f6c6ba1b29a9063dce09b4b3f8e15becb87c522a CHECKSUM(SHA256) upstream package : 23da0b9d120b27a0cc9b6b79f6c6ba1b29a9063dce09b4b3f8e15becb87c522a https://github.com/R4stl1n/cAudio/archive/v2.2.0.tar.gz : CHECKSUM(SHA256) this package : 3db823ba81365074c6c8214b17f89d1523bb7e1cd6d64408b882d1f824c5b17d CHECKSUM(SHA256) upstream package : 3db823ba81365074c6c8214b17f89d1523bb7e1cd6d64408b882d1f824c5b17d https://raw.githubusercontent.com/liballeg/allegro5/master/cmake/FindOgg.cmake : CHECKSUM(SHA256) this package : 035089f3f260b76c5244fdf0e0ca7b7b4febe9b85aa21b79270e597729460c06 CHECKSUM(SHA256) upstream package : 035089f3f260b76c5244fdf0e0ca7b7b4febe9b85aa21b79270e597729460c06 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1361320 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx