https://bugzilla.redhat.com/show_bug.cgi?id=1366878 --- Comment #2 from Eric Smith <spacewar@xxxxxxxxx> --- Spec URL: https://fedorapeople.org/~brouhaha/python-attrs/python-attrs.spec SRPM URL: https://fedorapeople.org/~brouhaha/python-attrs/python-attrs-16.0.0-2.fc24.src.rpm Thanks for the review! I made most of the requested changes, except: "Drop all this useless stuff": the useless stuff is needed to build for EPEL7. In fact, I discovered that I actually had to add a little bit more of the useless stuff to get it to build for EPEL7 in Koji. Unfortunately I can't yet get it to build for python-3.5 in EPEL7, but it does build for python-2.x. "is too generic" - is actually *exactly* per the example in the Fedora Packaging Guidelines for Python. I had specific files listed in another package review some time back, and the reviewer asked me to change to the more generic approach to match the guidelines. If I did make this one more generic, it would have to have both %{python2_sitelib}/attr because it doesn't have the trailing "s" of %{modname}, and %{python2_sitelib}/%{modname}-%{version}-py%{some_macro_to_get_specific_python_version_like_2.7}.egg-info I think the "too generic" version is simpler, more obvious, doesn't cause problems, and is compliant with the packaging guidelines. Let me know if you still want it changed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx