https://bugzilla.redhat.com/show_bug.cgi?id=1364542 --- Comment #20 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- (In reply to gil cattaneo from comment #14) > maybe the license field should be something like: > License: GPLv3+ and BSD and WTFPL and Boost and ISC and MIT and zlib and > LGPLv2+ Not really, "anding" licenses is intended for when e.g. different binaries are differently licensed -- and it's explicitly the licensing status of the binary program that this tag is about, see: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License:_field > Other question, field release seem not correct: > Release: 0.5%{?dist} That is intentional because that package is not yet in Fedora, it in fact is a pre-release from the packaging point of view ;). I'll bump the release to 1 when I build it in Fedora -- this way people who installed it from COPR should have a smooth update path. (In reply to gil cattaneo from comment #16) > and should be added: > Provides: bundled(AudioGrapher) = 0.0.0 > https://github.com/sbergen/AudioGrapher > > these files are under this term: > > /* > File: ACBaseCodec.cpp > Abstract: ACBaseCodec.h > Version: 1.1 You probably mean bundled(appleutility), not AudioGrapher, right? This library is only used when building on OS/X. (In reply to gil cattaneo from comment #17) > sorry but > > Provides: bundled(gtk-theme-engine-clearlooks > ) = unknown new Added that with version 2.9.0 (which is guaranteed not newer than the included code, guessed by copyright of 2007). AFAIK it's a customized fork of the clearlooks engine. > Provides: bundled(gtk-theme-engine-clearlooks > ) = unknown old not used (In reply to gil cattaneo from comment #18) > Provides: bundled(libsmf) = 1.2 > https://sourceforge.net/projects/libsmf/ Stripped down custom version, added + mention in LICENSING. > Provides: bundled(libltc) = 1.1.1 > https://github.com/x42/libltc/ We use the system version of the library, not added. > Provides: bundled(lua) = 5.3.3 > Ardour-5.0.0/libs/lua/lua-5.3.3/* > https://www.lua.org/ Comes with a custom C++-wrapper, added. > 1.0.2-111-g04b47d7 > https://github.com/vinniefalco/LuaBridge > under MIT License added (+ mention in LICENSING) > Provides: bundled(midi++) = 4.1.0 > Provides: bundled(pbd) = 4.1.0 internal to ardour (written by the ardour author) > http://www.quasimodo.org > ftp://ftp.quasimodo.org/pub/libs/midi++ "quasimodo.org is for sale!" ;) > Provides: bundled(qm-dsp) = 0.0.0 > https://code.soundsoftware.ac.uk/projects/qm-dsp We have that as a static library, I'll try unbundling it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx