[Bug 1276624] Review Request: swagger-core - Java implementation of Swagger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1276624



--- Comment #15 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Raphael Groner from comment #14)
> # org.powermock:powermock-module-testng:1.6.4
> %pom_remove_dep org.powermock:powermock-module-testng modules/swagger-models
> rm
> modules/swagger-models/src/test/java/io/swagger/models/ArrayModelTest.java \
>  modules/swagger-models/src/test/java/io/swagger/models/ModelImplTest.java
> 
> Available in Rawhide and F25:
> 
> * Wed Jun 01 2016 Michael Simacek <msimacek@xxxxxxxxxx> - 1.6.5-2
> - Enable TestNG module

NO compatible with the required version

(In reply to Raphael Groner from comment #13)
> #java.lang.AssertionError: expected [4] but found [2]
> rm -r modules/swagger-core/src/test/java/io/swagger/ModelConverterTest.java
> #java.lang.AssertionError: Serialized object:
> #{"in":"query","required":false,"type":"integer","default":1234,"format":
> "1nt64"}
> #does not equal to expected serialized string:
> #{"in":"query","required":false,"type":"integer","default":1234,"format":
> "1nt64"}
> rm -r
> modules/swagger-core/src/test/java/io/swagger/parameter/
> ParameterSerializationTest.java
> 
> Did you report to upstream?
No the problem happen because of jackson-dataformat-xml and woodstox libraries
(woodstox-core, stax2-api). i prefer remove these tests
(In reply to Raphael Groner from comment #12)
> APPROVED
> 
> Some advice/comments:
> 
> - Most of the java source files are without any license header to let our
> licensecheck script fail. Please poke upstream and ask to add everywhere the
> Apache header.

Reported @ https://github.com/swagger-api/swagger-core/issues/1882

> - My recommendation goes to use the same names for subpackages as the
> included pom files are named. E.g.:
>   %package jersey-jaxrs (better: %package -n swagger-jersey-jaxrs)
>   result: swagger-core-jersey-jaxrs (better: swagger-jersey-jaxrs)
>   /usr/share/maven-poms/swagger-core/swagger-jersey-jaxrs.pom
>   swagger-core/modules/swagger-jersey-jaxrs/pom.xml
> 
>   See https://fedoraproject.org/wiki/Packaging:Java#Filenames
i prefer in this way, and guideline do not specific the way of naming a
(sub)package(s)
> - There's a new version 1.5.9 at upstream.

for now i use/import this release

Spec URL: https://gil.fedorapeople.org/swagger-core.spec
SRPM URL: https://gil.fedorapeople.org/swagger-core-1.5.7-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]