[Bug 1366881] Review Request: ispc - C-based SPMD programming language compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366881

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ignatenko@xxxxxxxxxx



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> # Actual source is https://codeload.github.com/ispc/ispc/tar.gz/v1.9.1
> # Due to github structure, use that name below for compilation
> Source0:	https://github.com/ispc/ispc/archive/%{name}-%{version}.tar.gz 
Source0:
https://github.com/ispc/ispc/archive/v%{version}/%{name}-%{version}.tar.gz

> install -m 755 -d %{buildroot}/%{_bindir}
> cp -p %{name} %{buildroot}/%{_bindir}
install -Dpm0755 %{name} %{buildroot}%{_bindir}/%{name}

> BuildRequires:	flex-devel https://codeload.github.com/ispc/ispc/tar.gz/v1.9.1
that something strange

> BuildRequires:	bison-devel
I don't think you really need devel subpkg of bison and flex, I think main pkg
should be enough

* Missing BuildRequires: gcc-c++
* Missing BuildRequires: make
* CFLAGS and LDFLAGS are not enforced
-> I think %make_build OPT="%{optflags}" LDFLAGS="%{__global_ldflags}" should
fix problem

I didn't check other stuff yet due to problems above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]