[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #6 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> ---
Updated Spec URL: https://luya.fedorapeople.org/packages/SPECS/embree.spec
Updated SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/embree-2.10.0-3.fc24.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> %description should be wrapped to 80 columns, it's ~60 currently.
> 
> Why would you need to use %epoch? It's better avoided until absolutely
> necessary.
> 
Removed %epoch and adjusted the %descrpitions to 80 colums

> %{_bindir}/%{name}/models → it's very suspect to have subdirectories in
> /bin. Those executables don't end up in path anyway.

A result from upstream package. That path contained a bunch of binary tutorials
(disabled on built). These binary will not build due to missing avx.


> It's good practice to explicitly list files in %{_bindir} and %{_libdir} and
> %{includedir}, instead of using a wide pattern like %{_bindir}/*,
> %{_libdir}/*. And for libraries, to include the major version in the pattern:
> 
> %files
> ...
> %{_libdir}/libxxx.so.0
> %{_libdir}/libxxx.so.0.*
Fixed


> This protects against accidental so version bumps (which are forbidden in
> stable releases).
> 
> One BR per line please.
> 
> (In reply to Luya Tshimbalanga from comment #2)
> 
> > > Finally: Building this package doesn't honor RPM_OPT_FLAGS.
> > Unfortunately embree can be only built with 64-bit architectures. See
> > https://embree.github.io/downloads.html for requirement.
> >  I am not familiar with %{optflag} macro so I am open to suggestion.
> 
> See https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

Looking at it, I still don't see the point of %{optflag} for that purpose. =(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]