https://bugzilla.redhat.com/show_bug.cgi?id=1361584 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Errors in test suite output - There are worrying errors reported in test suite output, although the test suite passes. What is the reason for them? - Actually they appear randomly so probably not of concern.g * Unnecessary BR - BR: rubygem(rb-inotify) is not needed anymore, since updated version of listen pulls this automatically. - BR: rubygem(minitest) is pulled in via ActiveSupport. * Keep the disabled test file - I typically prefer to rename the test files I want to disable, since I can later review them if needed. But this is just a minor nit. Since all the points above are just minor nits I APPROVE the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx