[Bug 1364542] Review Request: ardour5 - Digital Audio Workstation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1364542



--- Comment #8 from gil cattaneo <puntogil@xxxxxxxxx> ---
Issues:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "WTFPL WTFPL (v2)", "LGPL (v2.1 or later) (with incorrect FSF
     address)", "LGPL (v2 or later) (with incorrect FSF address)", "*No
     copyright* BSD (3 clause)", "LGPL (v2.1) (with incorrect FSF
     address)", "GPL (v2.0)", "*No copyright* GPL (v2 or later)", "*No
     copyright* LGPL (v2.1 or later)", "*No copyright* GPL (v2 or later)
     (with incorrect FSF address)", "GPL (v3 or later)", "ISC",
     "zlib/libpng", "LGPL (v3 or later)", "GPL (v2 or later) (with
     incorrect FSF address)", "BSD (2 clause)", "*No copyright* LGPL (v2 or
     later) (with incorrect FSF address)", "GPL", "*No copyright* WTFPL",
     "GPL (v2 or later)", "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown
     or generated", "BSD (4 clause)", "BSL (v1.0)", "GPL (v2)". 778 files
     have unknown license. Detailed output of licensecheck in
     /home/gil/1364542-ardour5/licensecheck.txt
    See attached file
    BSL (v1.0) >> Boost

Most of the file have incorrect Free Software Foundation addres,
please, report to upstream
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

[!]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: ardour5
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
    Missing in %post

ardour5.i686: E: invalid-appdata-file /usr/share/appdata/ardour5.appdata.xml
please, check

NON blocking issues:

[?]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
   https://github.com/Ardour/ardour/archive/5.0/ardour-5.0.tar.gz

[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: # This macro creates a backend
     subpackage. Needs to be %%define, not %%global., %define
     backend_package() %package %{1}backend-%{lua:
     print(string.lower(rpm.expand("%2")))}Summary: %{2} %{1} backend for
     %{name}Requires: %{name}%{?_isa} =
     %{?epoch:%{epoch}:}%{version}-%{release}Provides:
     %{name}-%{1}backend%{?_isa}%{?3:License: %{3}}%description
     %{1}backend-%{lua: print(string.lower(rpm.expand("%2")))}This package
     provides the %{2} %{1} backend for Ardour.%files %{1}backend-%{lua:
    
print(string.lower(rpm.expand("%2")))}%{_libdir}/%{name}/backends/lib%{lua:
     print(string.lower(rpm.expand("%2")))}_%{1}backend.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]