https://bugzilla.redhat.com/show_bug.cgi?id=1364542 --- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "WTFPL WTFPL (v2)", "LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL (v2 or later) (with incorrect FSF address)", "*No copyright* BSD (3 clause)", "LGPL (v2.1) (with incorrect FSF address)", "GPL (v2.0)", "*No copyright* GPL (v2 or later)", "*No copyright* LGPL (v2.1 or later)", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "GPL (v3 or later)", "ISC", "zlib/libpng", "LGPL (v3 or later)", "GPL (v2 or later) (with incorrect FSF address)", "BSD (2 clause)", "*No copyright* LGPL (v2 or later) (with incorrect FSF address)", "GPL", "*No copyright* WTFPL", "GPL (v2 or later)", "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated", "BSD (4 clause)", "BSL (v1.0)", "GPL (v2)". 778 files have unknown license. Detailed output of licensecheck in /home/gil/1364542-ardour5/licensecheck.txt See attached file BSL (v1.0) >> Boost [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in ardour5 [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in ardour5 [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: update-mime-database is invoked in %post and %postun if package stores mime configuration in /usr/share/mime/packages. Note: mimeinfo files in: ardour5 See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ardour5-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [?]: Package does not include license text files separate from upstream. [?]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments See above comment [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: # This macro creates a backend subpackage. Needs to be %%define, not %%global., %define backend_package() %package %{1}backend-%{lua: print(string.lower(rpm.expand("%2")))}Summary: %{2} %{1} backend for %{name}Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}Provides: %{name}-%{1}backend%{?_isa}%{?3:License: %{3}}%description %{1}backend-%{lua: print(string.lower(rpm.expand("%2")))}This package provides the %{2} %{1} backend for Ardour.%files %{1}backend-%{lua: print(string.lower(rpm.expand("%2")))}%{_libdir}/%{name}/backends/lib%{lua: print(string.lower(rpm.expand("%2")))}_%{1}backend.so [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9236480 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ardour5-5.0.0-0.4.fc26.i686.rpm ardour5-audiobackend-alsa-5.0.0-0.4.fc26.i686.rpm ardour5-audiobackend-jack-5.0.0-0.4.fc26.i686.rpm ardour5-audiobackend-dummy-5.0.0-0.4.fc26.i686.rpm ardour5-debuginfo-5.0.0-0.4.fc26.i686.rpm ardour5-5.0.0-0.4.fc26.src.rpm ardour5.i686: W: spelling-error %description -l en_US Ardour -> Armour, Ar dour, Ar-dour ardour5.i686: W: spelling-error %description -l en_US multi -> mulch, mufti ardour5.i686: W: obsolete-not-provided ardour3 ardour5.i686: W: obsolete-not-provided ardour4 ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libqmdsp.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libevoral.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libardour.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/vamp/libardourvampplugins.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libmidipp.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libpbd.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libptformat.so ardour5.i686: W: dangling-relative-symlink /usr/share/ardour5/ArdourMono.ttf ../fonts/google-droid/DroidSansMono.ttf ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libaudiographer.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libcanvas.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libgtkmm2ext.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libardouralsautil.so ardour5.i686: W: no-manual-page-for-binary ardour5-lua ardour5.i686: W: no-manual-page-for-binary ardour5-copy-mixer ardour5.i686: W: no-manual-page-for-binary ardour5-export ardour5.i686: E: invalid-appdata-file /usr/share/appdata/ardour5.appdata.xml ardour5-audiobackend-alsa.i686: W: spelling-error Summary(en_US) backend -> backed, back end, back-end ardour5-audiobackend-alsa.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ardour5-audiobackend-alsa.i686: W: no-documentation ardour5-audiobackend-jack.i686: W: spelling-error Summary(en_US) backend -> backed, back end, back-end ardour5-audiobackend-jack.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ardour5-audiobackend-jack.i686: W: no-documentation ardour5-audiobackend-dummy.i686: W: spelling-error Summary(en_US) backend -> backed, back end, back-end ardour5-audiobackend-dummy.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ardour5-audiobackend-dummy.i686: W: no-documentation ... ardour5.src: W: spelling-error %description -l en_US Ardour -> Armour, Ar dour, Ar-dour ardour5.src: W: spelling-error %description -l en_US multi -> mulch, mufti ardour5.src:101: W: unversioned-explicit-obsoletes ardour3 ardour5.src:101: W: unversioned-explicit-obsoletes ardour4 ardour5.src:116: W: unversioned-explicit-provides %{name}-%{1}backend%{?_isa}\ ardour5.src: W: invalid-url Source0: Ardour-5.0.0.tar.bz2 6 packages and 0 specfiles checked; 1385 errors, 34 warnings. 1 packages and 0 specfiles checked; 1384 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- ardour5-audiobackend-jack.i686: W: spelling-error Summary(en_US) backend -> backed, back end, back-end ardour5-audiobackend-jack.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ardour5-audiobackend-jack.i686: W: no-documentation ardour5-audiobackend-alsa.i686: W: spelling-error Summary(en_US) backend -> backed, back end, back-end ardour5-audiobackend-alsa.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ardour5-audiobackend-alsa.i686: W: no-documentation ardour5.i686: W: spelling-error %description -l en_US Ardour -> Armour, Ar dour, Ar-dour ardour5.i686: W: spelling-error %description -l en_US multi -> mulch, mufti ardour5.i686: W: obsolete-not-provided ardour3 ardour5.i686: W: obsolete-not-provided ardour4 ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libgtkmm2ext.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libardour.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libevoral.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libaudiographer.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libcanvas.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libardouralsautil.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/vamp/libardourvampplugins.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libqmdsp.so ardour5.i686: W: dangling-relative-symlink /usr/share/ardour5/ArdourMono.ttf ../fonts/google-droid/DroidSansMono.ttf ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libpbd.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libmidipp.so ardour5.i686: W: devel-file-in-non-devel-package /usr/lib/ardour5/libptformat.so ardour5.i686: W: no-manual-page-for-binary ardour5-lua ardour5.i686: W: no-manual-page-for-binary ardour5-copy-mixer ardour5.i686: W: no-manual-page-for-binary ardour5-export ardour5-audiobackend-dummy.i686: W: spelling-error Summary(en_US) backend -> backed, back end, back-end ardour5-audiobackend-dummy.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end ardour5-audiobackend-dummy.i686: W: no-documentation ... 1 packages and 0 specfiles checked; 1384 errors, 0 warnings. NOTE see attached rpmlin.txt file Requires -------- ardour5-audiobackend-jack (rpmlib, GLIBC filtered): ardour5(x86-32) libasound.so.2 libaubio.so.4 libc.so.6 libcurl.so.4 libdl.so.2 libfftw3f.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgio-2.0.so.0 libgiomm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgobject-2.0.so.0 libgthread-2.0.so.0 libjack.so.0 liblilv-0.so.0 liblo.so.7 liblrdf.so.2 libltc.so.11 libm.so.6 libpthread.so.0 librubberband.so.2 libsamplerate.so.0 libserd-0.so.0 libsigc-2.0.so.0 libsndfile.so.1 libsord-0.so.0 libsratom-0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libsuil-0.so.0 libtag.so.1 libvamp-hostsdk.so.3 libvamp-sdk.so.2 libxml2.so.2 rtld(GNU_HASH) ardour5-audiobackend-alsa (rpmlib, GLIBC filtered): ardour5(x86-32) libasound.so.2 libasound.so.2(ALSA_0.9) libasound.so.2(ALSA_0.9.0rc4) libaubio.so.4 libc.so.6 libcurl.so.4 libdl.so.2 libfftw3f.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgio-2.0.so.0 libgiomm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgobject-2.0.so.0 libgthread-2.0.so.0 liblilv-0.so.0 liblo.so.7 liblrdf.so.2 libltc.so.11 libm.so.6 libpthread.so.0 librubberband.so.2 libsamplerate.so.0 libserd-0.so.0 libsigc-2.0.so.0 libsndfile.so.1 libsord-0.so.0 libsratom-0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libsuil-0.so.0 libtag.so.1 libvamp-hostsdk.so.3 libvamp-sdk.so.2 libxml2.so.2 rtld(GNU_HASH) ardour5 (rpmlib, GLIBC filtered): /bin/sh ardour5-audiobackend(x86-32) config(ardour5) google-droid-sans-mono-fonts libFLAC.so.8 libX11.so.6 libasound.so.2 libasound.so.2(ALSA_0.9) libasound.so.2(ALSA_0.9.0rc4) libatk-1.0.so.0 libatkmm-1.6.so.1 libaubio.so.4 libbluetooth.so.3 libc.so.6 libcairo.so.2 libcairomm-1.0.so.1 libcurl.so.4 libcwiid.so.1 libdbus-1.so.3 libdbus-1.so.3(LIBDBUS_1_3) libdl.so.2 libfftw3f.so.3 libfontconfig.so.1 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.4) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgdkmm-2.4.so.1 libgio-2.0.so.0 libgiomm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libgtkmm-2.4.so.1 liblilv-0.so.0 liblo.so.7 liblrdf.so.2 libltc.so.11 libm.so.6 libogg.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpangomm-1.4.so.1 libpthread.so.0 libreadline.so.6 librubberband.so.2 libsamplerate.so.0 libsamplerate.so.0(libsamplerate.so.0.0) libserd-0.so.0 libsigc-2.0.so.0 libsndfile.so.1 libsndfile.so.1(libsndfile.so.1.0) libsord-0.so.0 libsratom-0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.1) libstdc++.so.6(CXXABI_1.3.8) libsuil-0.so.0 libtag.so.1 libvamp-hostsdk.so.3 libvamp-sdk.so.2 libxml2.so.2 libxml2.so.2(LIBXML2_2.4.30) libxml2.so.2(LIBXML2_2.6.0) rtld(GNU_HASH) ardour5-audiobackend-dummy (rpmlib, GLIBC filtered): ardour5(x86-32) libaubio.so.4 libc.so.6 libcurl.so.4 libdl.so.2 libfftw3f.so.3 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgio-2.0.so.0 libgiomm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgobject-2.0.so.0 libgthread-2.0.so.0 liblilv-0.so.0 liblo.so.7 liblrdf.so.2 libltc.so.11 libm.so.6 libpthread.so.0 librubberband.so.2 libsamplerate.so.0 libserd-0.so.0 libsigc-2.0.so.0 libsndfile.so.1 libsord-0.so.0 libsratom-0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libsuil-0.so.0 libtag.so.1 libvamp-hostsdk.so.3 libvamp-sdk.so.2 libxml2.so.2 rtld(GNU_HASH) ardour5-debuginfo (rpmlib, GLIBC filtered): Provides -------- ardour5-audiobackend-jack: ardour5-audiobackend(x86-32) ardour5-audiobackend-jack ardour5-audiobackend-jack(x86-32) ardour5-audiobackend-alsa: ardour5-audiobackend(x86-32) ardour5-audiobackend-alsa ardour5-audiobackend-alsa(x86-32) ardour5: appdata() appdata(ardour5.appdata.xml) application() application(ardour5.desktop) ardour5 ardour5(x86-32) config(ardour5) mimehandler(application/x-ardour) ardour5-audiobackend-dummy: ardour5-audiobackend(x86-32) ardour5-audiobackend-dummy ardour5-audiobackend-dummy(x86-32) ardour5-debuginfo: ardour5-debuginfo ardour5-debuginfo(x86-32) Unversioned so-files -------------------- ardour5: /usr/lib/ardour5/LV2/a-comp.lv2/a-comp.so ardour5: /usr/lib/ardour5/LV2/a-delay.lv2/a-delay.so ardour5: /usr/lib/ardour5/LV2/a-eq.lv2/a-eq.so ardour5: /usr/lib/ardour5/LV2/a-reverb.lv2/a-reverb.so ardour5: /usr/lib/ardour5/LV2/reasonablesynth.lv2/reasonablesynth.so ardour5: /usr/lib/ardour5/engines/libclearlooks.so ardour5: /usr/lib/ardour5/libardour.so ardour5: /usr/lib/ardour5/libardouralsautil.so ardour5: /usr/lib/ardour5/libardourcp.so ardour5: /usr/lib/ardour5/libaudiographer.so ardour5: /usr/lib/ardour5/libcanvas.so ardour5: /usr/lib/ardour5/libevoral.so ardour5: /usr/lib/ardour5/libgtkmm2ext.so ardour5: /usr/lib/ardour5/libmidipp.so ardour5: /usr/lib/ardour5/libpbd.so ardour5: /usr/lib/ardour5/libptformat.so ardour5: /usr/lib/ardour5/libqmdsp.so ardour5: /usr/lib/ardour5/libtimecode.so ardour5: /usr/lib/ardour5/panners/libpan1in2out.so ardour5: /usr/lib/ardour5/panners/libpan2in2out.so ardour5: /usr/lib/ardour5/panners/libpanbalance.so ardour5: /usr/lib/ardour5/panners/libpanvbap.so ardour5: /usr/lib/ardour5/surfaces/libardour_faderport.so ardour5: /usr/lib/ardour5/surfaces/libardour_generic_midi.so ardour5: /usr/lib/ardour5/surfaces/libardour_mcp.so ardour5: /usr/lib/ardour5/surfaces/libardour_osc.so ardour5: /usr/lib/ardour5/surfaces/libardour_wiimote.so ardour5: /usr/lib/ardour5/vamp/libardourvampplugins.so ardour5-audiobackend-alsa: /usr/lib/ardour5/backends/libalsa_audiobackend.so ardour5-audiobackend-jack: /usr/lib/ardour5/backends/libjack_audiobackend.so ardour5-audiobackend-dummy: /usr/lib/ardour5/backends/libdummy_audiobackend.so Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1364542 --plugins C/C++ -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx