https://bugzilla.redhat.com/show_bug.cgi?id=1360365 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- %{sum} macro is not necessary, you can write Summary: normally first time, and then use Summary: %{summary} for the subsequent ones. You don't need to actually delete .egg-info. + package name is OK + license is acceptable (MIT) + license is specified correctly + standard python packaging is used + python_provide is used + no scriptlets present or necessary - builds and installs OK ? P/R/BR look OK %check fails in mock, looks like you need BR's on mock too. ----------------------------- Captured stderr call ----------------------------- nomatch: '*"mock" fixture has been deprecated*' and: u'' ________________________ test_mocker_aliases[MagicMock] ________________________ name = 'MagicMock' @pytest.mark.parametrize('name', ['MagicMock', 'PropertyMock', 'Mock', 'call', 'ANY']) def test_mocker_aliases(name): > from pytest_mock import mock_module, MockFixture test_pytest_mock.py:137: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ import inspect import sys import pytest if sys.version_info >= (3, 3): # pragma: no cover import unittest.mock as mock_module else: > import mock as mock_module E ImportError: No module named mock pytest_mock.py:9: ImportError -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx