https://bugzilla.redhat.com/show_bug.cgi?id=1365745 Igor Gnatenko <ignatenko@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Summary|Review Request: fwknop-gui |Review Request: fwknop-gui |- a cross platform gui that |- GUI client for Fwknop |can save and send knocks to | |a server running fwknopd | Flags|fedora-review? |fedora-review+ --- Comment #3 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- you missed to address: > desktop-file-validate %{buildroot}%{_datadir}/applications/fwknop-gui.desktop > appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml 1. drop "/" after %{buildroot} 2. replace "fwknop-gui" with "%{name}" 3. Move to separate %check section Also I completely forgot: > Release: 2 it must be 2%{?dist} Others looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx