[Bug 1361687] Review Request: python-isort - A Python utility / library to sort Python imports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1361687

Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |limburgher@xxxxxxxxx
              Flags|                            |needinfo?(limburgher@gmail.
                   |                            |com)



--- Comment #6 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> ---
Hello Jon!

Thanks for fixing the license. The executable names still do not follow the
Fedora guidelines I cited. I'll be a little more specific. The spec file
currently generates these files:

$ ls rpms-unpacked/python2-isort-4.2.5-2.fc26.noarch.rpm/usr/bin/ -l
total 4
lrwxrwxrwx. 1 rbarlow rbarlow  17 Aug  9 14:57 isort -> /usr/bin/isort2.7
-rwxr-xr-x. 1 rbarlow rbarlow 292 Aug  9 14:55 isort2.7
$ ls rpms-unpacked/python3-isort-4.2.5-2.fc26.noarch.rpm/usr/bin/ -l
total 4
-rwxr-xr-x. 1 rbarlow rbarlow 292 Aug  9 14:55 isort3.5

According to the Python packaging guidelines, it *should* be generating these
files:

/usr/bin/isort -> /usr/bin/isort-2.7
/usr/bin/isort-2 -> /usr/bin/isort-2.7
/usr/bin/isort-2.7
/usr/bin/isort-3 -> /usr/bin/isort-3.5
/usr/bin/isort-3.5

In particular, this spec file is missing the dashes and the -2 and -3 symlinks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]