https://bugzilla.redhat.com/show_bug.cgi?id=1308561 --- Comment #15 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- (In reply to Fabio Alessandro Locati from comment #14) > (In reply to Igor Gnatenko from comment #13) > > > Suggests: xorg-x11-server-Xwayland > > it doesn't make sense. convert to Recommends or drop. > > Why? > Recomments does not make sense IMHO since it can work properly without xorg > dependencies. Dropping it could be an idea (and was the situation before my > last update) but I think it's worth pointing it out since some user could > want to run X apps on it (without having the whole xorg installed). Suggests means to prefer one package over the other, for example: * Package: bar Provides: foo * Package: baz Provides: foo * Package: sway Suggests: bar dnf install sway will install only sway. now you do dnf install foo and most likely (it's too complicated process) "bar" instead of "baz" will be installed as sway has Suggests. > > > > > > -DCMAKE_BUILD_TYPE=Release \ > > drop this > > In the Sway documentation is suggested to use it. Is there some Fedora > reason to not have it? because debuginfo will be broken, %cmake defines it as RelWithDebInfo. > > > > -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir} \ > > drop it. > > In the Sway documentation is suggested to use it. Is there some Fedora > reason to not have it? defined by %cmake. > > > consider making out-of-tree build > > What do you mean? Why should I consider makin out-of-tree build? because it's good practice. > %prep > ... > mkdir %{_target_platform} > %build > pushd %{_target_platform} > %cmake .. > popd > %make_build -C %{_target_platform} > %install > %make_install -C %{_target_platform} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx