[Bug 1365399] Review Request: python-aaargh - An astonishingly awesome application argument helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1365399

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> %license PKG-INFO
it's not license and doesn't contain any interesting stuff, so drop it

> %{python2_sitelib}/%{srcname}/*.py*
> %{python3_sitelib}/%{srcname}/__pycache__/
> %{python3_sitelib}/%{srcname}/*.py
and who owns base directory?

> BuildRequires:  python2-devel
> BuildRequires:  python3-devel
move under subpakcages.

* Tests are present, but not ran
* Missing BuildRequires: pythonX-setuptools
* Don't copy-paste description, do something like:
> %global description \
> foo bar\
> baz.
> %description %{_description}
> %description -n python2-%{srcname} %{_description}
> 
> Python 2 version
> ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]