https://bugzilla.redhat.com/show_bug.cgi?id=1362490 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Quick look. 1/ cp -a * %{buildroot}%{_datadir}/%{name}/ This look very ugly, I think lot of files are unneeded at runtime (documentation, license, tests...) 2/ JsonLInt is available as system library: php-jsonlint-1.4.0 $jsonlint_root = phutil_get_library_root('phutil').'/../externals/jsonlint'; require_once $jsonlint_root.'/src/Seld/JsonLint/JsonParser.php'; require_once $jsonlint_root.'/src/Seld/JsonLint/Lexer.php'; require_once $jsonlint_root.'/src/Seld/JsonLint/ParsingException.php'; require_once $jsonlint_root.'/src/Seld/JsonLint/Undefined.php'; => require_once '/usr/share/php/Seld/JsonLint/autoload.php'; 3/ Requires: php-common >= 5 See PHP Guidelines, and attached phpci.log (phpcompatinfo static analysis result) You must not use package names, but extensions name. Version doesn't make sense (we don't have anything < 5) Requires: php-reflection Requires: php-simplexml Requires: php-ctype Requires: php-curl Requires: php-date ... apc, memcache, xhprof are very probably optional, need code check. 4/ you cannot keep jsonlint in the archive, you have to remove it. Non-free software must go in the repo, even in .src.rpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx