https://bugzilla.redhat.com/show_bug.cgi?id=1363825 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-LWP-UserAgent-DNS-Hosts-0.08-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.8.1 1 perl(Carp) 1 perl(LWP::Protocol) 1 perl(LWP::Protocol::http) 1 perl(LWP::Protocol::https) 1 perl(LWP::UserAgent::DNS::Hosts) 1 perl(Scope::Guard) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-LWP-UserAgent-DNS-Hosts-0.08-1.fc26.noarch.rpm | sort | uniq -c 1 perl(LWP::Protocol::http::hosts) 1 perl(LWP::Protocol::https::hosts) 1 perl(LWP::UserAgent::DNS::Hosts) = 0.08 1 perl-LWP-UserAgent-DNS-Hosts = 0.08-1.fc26 Binary provides are Ok. $ rpmlint ./perl-LWP-UserAgent-DNS-Hosts* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok FIX: Please add missing build requires - make (spec file, lines 45, 49, 55) - findutils (spec file, line 50) - in case you do not remove the command - perl(Carp) - lib/LWP/UserAgent/DNS/Hosts.pm:6 - perl(strict) - perl(warnings) FIX: Remove all the bundled Module::Install files from ./inc, build-require `perl(inc::Module::Install)' and other needed modules from Module::Install namespace (locate functions called from Makefile.PL). Or declare all build-time dependencies for the bundled Module::Install modules. TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. TODO: Use plain 'perl' command instead of %{__perl} macro and build-require 'perl'. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx