https://bugzilla.redhat.com/show_bug.cgi?id=1327218 Igor Gnatenko <ignatenko@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ignatenko@redhat. |needinfo?(olysonek@redhat.c |com) |om) --- Comment #3 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- > - The Release field should contain the snapshot date > https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Snapshot_packages thanks, but I'm not going to do that. > - The BINDIR and INCDIR variables used in Makefile should probably be overriden > from spec file by the %{_bindir} and %{_includedir} macros When it will stop working, then I will do something about that. > - Please apply the attached patch to make the spec file cleaner ok, will do. > - Perhaps the documentation at > http://bazaar.launchpad.net/~leonerd/libvterm/trunk/files/head:/doc/ > could be included (perhaps in the -devel subpackage?) no, that's too much work. > - The executables unterm, vterm-ctrl and vterm-dump could have some man pages feel free to write it. Any real issues? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx