[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1357064



--- Comment #9 from Sandro Mani <manisandro@xxxxxxxxx> ---
I'm not sure these are correct:
Enhances:      %{name} = %{version}-%{release}\
Supplements:   (%{name} = %{version}-%{release} and langpacks-%{1})\

Reading the bottom section of [1], I think

Enhances:      %{name} = %{version}-%{release}
Requires:      %{name} = %{version}-%{release}

would be more correct. Enhances may be used by the package manager to notify
the user about the additional packages, and Requires ensures you don't need to
install the license in each langpack (because it is installed by
lumina-desktop-libs required by lumina-desktop), and that directory ownership
is also correct.


Also, -devel does not need to install the LICENSE separately because it is
already installed by -libs which it requires.

Rest looks good.

[1]
http://www.rpm.org/wiki/PackagerDocs/Dependencies&num=1&hl=en&gl=ch&strip=0&vwsrc=0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]