Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review request: qtpfsgui - A Qt4 graphical user interface that provides a workflow for HDR imaging https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246460 ------- Additional Comments From silfreed@xxxxxxxxxxxx 2007-07-04 09:04 EST ------- (In reply to comment #5) > The summary could be a bit less cryptic: > > A graphical tool for creating and tone-mapping HDR images > > ..and the description should say a bit more: > > Qtpfsgui is a graphical program for assembling bracketed photos into High > Dynamic Range (HDR) images. It also provides a number of tone-mapping > operators for creating low dynamic range versions of HDR images. Thanks for the improved summary and description; I was having a hard time coming up with decent ones myself (as you saw ;). > I would fix the newlines in %prep and not %install, but this isn't important. Okay. Is there any general guideline as to what should be done in %prep and what should be done in %install? I've mostly kept my %prep sections to run %setup and %patch, but since I was just fixing a file that was being pulled in by %doc, I could see how it would make more sense to be moved there since it wasn't being installed by %install. > You can call 'desktop-file-install' with '--delete-original', then you don't > have to manually delete it afterwards Excellent! I'll pull that in as well. I should have new packages up shortly. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review