[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1364603



--- Comment #3 from Haïkel Guémar <karlthered@xxxxxxxxx> ---
* To respect guidelines the "xstatic-angular-schema-form-common" should be
renamed as js-%{pypi_name}.
https://fedoraproject.org/wiki/Packaging:JavaScript#Naming_Guidelines
But as it may conflict with a future package for this library -rationale behing
the previous XStatic packages-, it's ok.

* You should version requires on the js library subpackage
Requires:       xstatic-angular-schema-form-common = %{version}-%{release}

The XStatic package has been tested with a specific version, so you'd want to
tie them together so that if you upgrade
python-xstatic-angular-schemar-form-common, it also upgrades the js subpackage.

* keep the data subdirectory in the install path of the js library, it is
actually part of the "API". As you see, Horizon is picking it up at a very
specific location. By relocating it, you'll just break Horizon at runtime.
https://github.com/openstack/horizon/blob/216e67371764ca329a73d63c6d187283b01db067/horizon/karma.conf.js#L87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]