https://bugzilla.redhat.com/show_bug.cgi?id=1361687 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |randy@xxxxxxxxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |randy@xxxxxxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #4 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Hello Jon! The true upstream for this project is on github, and you will find a LICENSE file there. I recommend using github as your Source0 so that you have the LICENSE file in your source, rather than copying it in manually. PyPI packages do not contain a snapshot of the source repository, but are rather made by setup.py and are usually missing a lot of repository files (like LICENSE). Another issue to fix are the names of the executables. See my note below about that. I put two other notes as well, but they are both optional and are at your discretion. If you fix the license and the executable names, you'll be good to go! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. bowlofeggs: Please add the %license macros in the %files sections. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/rbarlow/reviews/1361687-python-isort/licensecheck.txt [!]: License file installed when any subpackage combination is installed. bowlofeggs: The %license macros will fix this. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python bowlofeggs: The executable names aren't quite right. They should be named with a dash and then the Python major/minor versions. For example, the Python 2 package should make isort-2 and isort-2.7, instead of isort2. There are macros you can use to automatically set the .Y, but I can't remember what they are off the top of my head. For the policy around the names, see: https://fedoraproject.org/wiki/Packaging:Python#Naming /usr/bin/isort does correctly use Python 2. [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-isort , python3-isort [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. bowlofeggs: Upstream does appear to have some tests. You could run them in your spec file, but I consider that to be optional. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== bowlofeggs (optional): [!]: Consider working with upstream to create a manpage for the executable. Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-isort-4.2.5-1.fc26.noarch.rpm python3-isort-4.2.5-1.fc26.noarch.rpm python-isort-4.2.5-1.fc26.src.rpm python2-isort.noarch: W: no-manual-page-for-binary isort2 python2-isort.noarch: W: no-manual-page-for-binary isort python3-isort.noarch: W: no-manual-page-for-binary isort3 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- python3-isort.noarch: W: no-manual-page-for-binary isort3 python2-isort.noarch: W: no-manual-page-for-binary isort python2-isort.noarch: W: no-manual-page-for-binary isort2 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- python3-isort (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python2-isort (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) Provides -------- python3-isort: python3-isort python3.5dist(isort) python2-isort: python-isort python2-isort python2.7dist(isort) Source checksums ---------------- https://files.pythonhosted.org/packages/source/i/isort/isort-4.2.5.tar.gz : CHECKSUM(SHA256) this package : 56b20044f43cf6e6783fe95d054e754acca52dd43fbe9277c1bdff835537ea5c CHECKSUM(SHA256) upstream package : 56b20044f43cf6e6783fe95d054e754acca52dd43fbe9277c1bdff835537ea5c Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1361687 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx