[Bug 1356739] Review Request: zulucrypt - Qt GUI front end to cryptsetup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1356739



--- Comment #21 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to gil cattaneo from comment #20)
> Issues:
> 
> [!]: Package contains no bundled libraries without FPC exception.
>  See Comment#18

zulucrypt:
    application()
    application(zuluCrypt.desktop)
    application(zuluMount.desktop)
    bundled(md5-openssl)
    bundled(tcplay)

I don't understand comment#18, we need 'Provides: bundled(tcplay)'. See open
discussion in comment #16.
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries

> [?]: Packages should try to preserve timestamps of original installed
>      files.
>   See @ line 188 of the spec file, maybe you should also use "-p"

Can fix while importing the package.

> Please, fix also these problem:
> zulucrypt.i686: W: incoherent-version-in-changelog
> 5.0.0-2.20160802git064e9db.fc25 ['5.0.0-2.20160802git064e9db.fc26',
> '5.0.0-2.20160802git064e9db']

Hmpf, maybe uploaded an old SRPM. It's fixed in spec file.

> zulucrypt.src:160: W: macro-in-comment %{_includedir}

This is part of (commented) preparation to unbundle tcplay. Currently not
possible to apply, see above. Should I drop the commented lines?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]