https://bugzilla.redhat.com/show_bug.cgi?id=1362265 --- Comment #11 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- > %if 0%{?rhel} && 0%{?rhel} <= 5 > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > %endif why do you want to have this? you're not building this package for EL5. > Source0: https://github.com/%{gituser}/%{gitname}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz if you build from commit then you should specify it in Release tag, otherwise you should build from tag. > #bison grammar parsers in libyara/* are licensed under ASL 2.0 and GPLv2+ license. > License: ASL 2.0 and GPLv2 you say that it's GPLv2+, but write GPLv2 > Requires: pkgconfig drop this from -devel subpkg as it doesn't really need it > Requires: zlib-devel should have %{?_isa} in the end > %defattr(-,root,root,-) drop it > Group: Development/Libraries consider removing Group tags from all packages. * Missing BuildRequires: gcc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx