https://bugzilla.redhat.com/show_bug.cgi?id=1362265 --- Comment #7 from Michal Ambroz <rebus@xxxxxxxxx> --- Update to version 3.5.0 SPEC URL: https://rebus.fedorapeople.org/SPECS/yara.spec SRPM URL: https://rebus.fedorapeople.org/SRPMS/yara-3.5.0-1.fc23.src.rpm Build on COPR: https://copr.fedorainfracloud.org/coprs/rebus/infosec-rebus/build/438010/ >Note: License file COPYING is not marked as %license I have added COPYING to license% - sorry i forgot to change this >Please, follow naming of python package according to the packaging guidelines for Python. in version 3.5.0 all python stuff was removed from the yara package and was moved to separate package yara-python. I will be submitting new package review for python-yara package to continue with this stuff. >- BuildRoot: is for EPEL5 only. I have canged conditions to apply only for rhel <= 5 although packaging guidelines is not prohibiting this one, just saying it is not necessary https://fedoraproject.org/wiki/Packaging:Guidelines >- Some libyara/* files are licensed under GPLv2+ license. Please, include it in the License line. I have added the GPLv2+ note on the license field and explaning notes. Although all files having GPLv2+ license are the bison grammars which by the already present exception can be also licensed as the package containing those - in this case ASL v2.0 >- Required package lines are not fully versioned arch-specific: I have changed to the recommended version checking >- Compiler uses additional flags like "-O3 -Wall -Wno-deprecated-declarations". >Set AM_CFLAGS variable with 'make' by using default Fedora flags. I believe there is no need to override the AM_CFLAGS. The idea is that tools should invoke: gcc $AM_CFLAGS $CFLAGS file.c -o file.o In this way if there is something set in $AM_CFLAGS (what the author of the program thought should be set), it can be always overrode by users (in this case packager's resp. distribution) CFLAGS. As in the yara build scripts the %optflags are already configured by the %configure macro when running ./configure and then stored in the makefiles in form of CFLAGS, it is not needed or wanted to override any of AM_CFLAGS nor CFLAGS as it overrides also "-pthread" where necessary. >- Build HTML documentation I have created subpackage doc with the HTML documentation >- Please, remove commented commands. done >- You can run (Python2/Python3) tests by using 'python(3)-nose'. Will do in python-yara. >- Fix the warning: incoherent-version-in-changelog 3.4.0-4 ['3.4.0-5.fc25', '3.4.0-5'] done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx