https://bugzilla.redhat.com/show_bug.cgi?id=1353001 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK + latest version + license is acceptable - license is specified correctly: the license is GPLv3+, not GPLv3, according to headers + no scriptlets present or necessary - appdata file is present (but see below) + package builds and installs OK + provides/requires look sane Package is APPROVED, please fix up when uploading. -- appstream-util validate says: • tag-invalid : <metadata_license> is not valid [GPLv3] • tag-invalid : <project_license> is not valid [GPLv3]SPDX ID 'GPLv3' unknown Correct spdx tag is GPL-3.0+ • tag-missing : <translation> not specified • tag-missing : <update_contact> is not present You should probably use your maintainer e-mail here. • style-invalid : Not enough <screenshot> tags Without screenshots the package looks bad in gnome-software :( • tag-missing : <name> is not present • tag-missing : <summary> is not present Those two should be added. It would be nice to fix the appdata file to also pass validate without warnings (%check should continue to use validate-relax --nonet). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx