https://bugzilla.redhat.com/show_bug.cgi?id=1361883 --- Comment #4 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- Thanks for taking the review! (In reply to Igor Gnatenko from comment #3) > > Requires: pkgconfig > not needed The pkgconfig package contains the %{_libdir}/pkgconfig directory and is normally used for building with the library. > > Summary: libmypaint development files > summary should start from upper-case fixed > > make %{?_smp_mflags} > should be changed to %make_build > > > make DESTDIR=%{buildroot} install > should be changed to %make_install > > > rm -f %{buildroot}%{_libdir}/*.la > personally I prefer to do: find %{buildroot}%{_libdir} -name '*.la' -delete > -print thanks for the suggestions, fixed > > %{_libdir}/girepository-1.0 > %dir %{_libdir}/girepository-1.0 > %{_libdir}/girepository-1.0/... specify here file > > same for gir directory Why? Listing the directory and the files separately, or just the directory recursively doesn't make a difference in the result. > > # files missing from tarball > why not to use git-tag tarball instead of make-dist tarball? Because git-tagged tarballs don't include all files contained in a make-dist tarball, and we're ultimately targeting official releases. > > No known owner of /usr/share/locale/ar_AR/LC_MESSAGES, /usr/share/locale/ar_AR > That's interesting... Can you check if it's correct locale name "ar_AR" and > if it is, please open bug against package "filesystem" which doesn't know > anything about that lang. I'm pretty sure it isn't a correct locale name, I've submitted a fix/pull request to rename the file: https://github.com/mypaint/libmypaint/pull/63 > > libmypaint-devel.x86_64: W: spelling-error %description -l en_US constains -> contains, constrains, con stains > fix it please. fixed > > libmypaint.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmypaint-1.3.so.0.0.0 /lib64/libglib-2.0.so.0 > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_get > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_object_unref > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 mypaint_tiled_surface_init > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_set > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_iterator_next > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_assertion_message_expr > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_return_if_fail_warning > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_node_new_child > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_object_new > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_get_format > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_node_new > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_malloc > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_object_ref > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_free > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 babl_format_get_bytes_per_pixel > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 babl_type > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 babl_format_new > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 mypaint_surface_ref > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_log > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_iterator_new > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_get_type > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_node_link > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_rectangle_bounding_box > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_type_check_instance_is_a > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 babl_component > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_type_check_instance_cast > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_buffer_set_extent > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_boxed_type_register_static > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 babl_model > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 g_object_get > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 mypaint_surface_unref > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 mypaint_tiled_surface_destroy > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_node_process > > libmypaint.x86_64: W: undefined-non-weak-symbol /usr/lib64/libmypaint-gegl.so.0.0.0 gegl_rectangle_set > > libmypaint.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmypaint-gegl.so.0.0.0 /lib64/libm.so.6 > > libmypaint.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libmypaint-gegl.so.0.0.0 /lib64/libpthread.so.0 > report bug upstream, please https://github.com/mypaint/libmypaint/issues/64 > > BuildRequires: python > > BuildRequires: python-devel > I guess you need none of them removed > > BuildRequires: python-sphinx > libmypaint explicitly requires sphinx-build-2, su change to python2-sphinx. Fedora 23 doesn't know about python2-sphinx, I've fixed that for Fedora 24 and later. > * Missing BR: gcc added > * Looks like you build docs, but they're not getting installed included as %doc in the -devel subpackage Spec File: http://copr-dist-git.fedorainfracloud.org/cgit/nphilipp/gimp-unstable/libmypaint.git/plain/libmypaint.spec?id=6fcf4039c256ef290703cb9f84b5cb91c94c5822 SRPM: https://copr-be.cloud.fedoraproject.org/results/nphilipp/gimp-unstable/fedora-rawhide-x86_64/00430631-libmypaint/libmypaint-1.3.0-0.2.beta.1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx