https://bugzilla.redhat.com/show_bug.cgi?id=1338339 --- Comment #13 from Antonio Trande <anto.trande@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python2-openrave : /usr/lib/python2.7/site- packages/openravepy/_openravepy_/ikfast.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages I'm not sure where python header files must be installed, but i guess they should be pushed under an include directory. - plugins/rplanners/ParabolicPathSmooth (BSD) These files are involved in the building and licensed under BSD license. I think, you should include BSD with LGPLv3+ and ASL 2.0 - examples/doormanipulation/SetupWAMScene.m examples/doormanipulation/rundoormanipulation.m are licensed under GPLv3+; this license should be included in the octave sub-package. - Bundled plugins/include/boost/* files should be erased - %{_datadir}/%{name} is not owned - Latest stable released version is the 0.8.2 Are you sure this is not a pre-release of 0.9.0 ? - There are tests. Why are not performed ? - Octave files should be installed in %{octpkglibdir} ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [?]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL", "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSL (v1.0)", "*No copyright* LGPL", "*No copyright* Public domain", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL (v3 or later)", "BSD (3 clause)", "BSD (2 clause)", "zlib/libpng". 244 files have unknown license. Detailed output of licensecheck in /home/sagitter/1338339-openrave/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/octave/packages [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/openrave, /usr/lib/cmake, /usr/libexec/octave/packages [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [?]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [-]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openrave-models , openrave-doc , openrave-debuginfo [ ]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2795520 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openrave-0.9.0-16.git8bfb8a6.fc25.i686.rpm openrave-devel-0.9.0-16.git8bfb8a6.fc25.i686.rpm openrave-models-0.9.0-16.git8bfb8a6.fc25.noarch.rpm openrave-doc-0.9.0-16.git8bfb8a6.fc25.noarch.rpm python2-openrave-0.9.0-16.git8bfb8a6.fc25.i686.rpm openrave-octave-0.9.0-16.git8bfb8a6.fc25.i686.rpm openrave-debuginfo-0.9.0-16.git8bfb8a6.fc25.i686.rpm openrave-0.9.0-16.git8bfb8a6.fc25.src.rpm openrave.i686: W: shared-lib-calls-exit /usr/lib/libopenrave-core.so.0.9.0 exit@GLIBC_2.0 openrave.i686: W: no-documentation openrave.i686: W: no-manual-page-for-binary openrave openrave-devel.i686: W: no-documentation openrave-devel.i686: W: no-manual-page-for-binary openrave-config openrave-devel.i686: W: no-manual-page-for-binary openrave-createplugin openrave-models.noarch: W: no-documentation python2-openrave.i686: W: no-documentation python2-openrave.i686: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/openravepy/_openravepy_/ikfast.h python2-openrave.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openravepy/_openravepy_/ikfast_generator_cpp_sympy0_6.py 644 /usr/bin/python2 python2-openrave.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openravepy/_openravepy_/ikfast_generator_cpp.py 644 /usr/bin/python2 python2-openrave.i686: W: no-manual-page-for-binary openrave-robot.py python2-openrave.i686: W: no-manual-page-for-binary openrave.py openrave-octave.i686: W: no-documentation openrave.src:51: W: unversioned-explicit-provides bundled(ivcon) 8 packages and 0 specfiles checked; 2 errors, 13 warnings. Rpmlint (debuginfo) ------------------- Checking: openrave-debuginfo-0.9.0-16.git8bfb8a6.fc25.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python2-openrave.i686: W: no-documentation python2-openrave.i686: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/openravepy/_openravepy_/ikfast.h python2-openrave.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openravepy/_openravepy_/ikfast_generator_cpp_sympy0_6.py 644 /usr/bin/python2 python2-openrave.i686: E: non-executable-script /usr/lib/python2.7/site-packages/openravepy/_openravepy_/ikfast_generator_cpp.py 644 /usr/bin/python2 python2-openrave.i686: W: no-manual-page-for-binary openrave.py python2-openrave.i686: W: no-manual-page-for-binary openrave-robot.py openrave-octave.i686: W: no-documentation openrave-models.noarch: W: no-documentation openrave-devel.i686: W: no-documentation openrave-devel.i686: W: no-manual-page-for-binary openrave-createplugin openrave-devel.i686: W: no-manual-page-for-binary openrave-config openrave.i686: W: shared-lib-calls-exit /usr/lib/libopenrave-core.so.0.9.0 exit@GLIBC_2.0 openrave.i686: W: no-documentation openrave.i686: W: no-manual-page-for-binary openrave 7 packages and 0 specfiles checked; 2 errors, 12 warnings. Requires -------- python2-openrave (rpmlib, GLIBC filtered): /usr/bin/python2 flann-python libANN.so.1 libboost_python.so.1.60.0 libboost_system.so.1.60.0 libboost_thread.so.1.60.0 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libopenrave-core.so.0 libopenrave.so.0 libpython2.7.so.1.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.8) libstdc++.so.6(CXXABI_1.3.9) openrave(x86-32) python(abi) rtld(GNU_HASH) sympy openrave-octave (rpmlib, GLIBC filtered): octave(api) openrave(x86-32) openrave-models (rpmlib, GLIBC filtered): openrave-doc (rpmlib, GLIBC filtered): openrave-debuginfo (rpmlib, GLIBC filtered): openrave-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/pkg-config libopenrave-core.so.0 libopenrave-core_c.so.0 libopenrave.so.0 libopenrave_c.so.0 openrave(x86-32) python2-openrave(x86-32) openrave (rpmlib, GLIBC filtered): /sbin/ldconfig libCoin.so.60 libOpenThreads.so.20 libQtCore.so.4 libQtGui.so.4 libSoQt.so.20 libX11.so.6 libassimp.so.3 libboost_filesystem.so.1.60.0 libboost_iostreams.so.1.60.0 libboost_system.so.1.60.0 libboost_thread.so.1.60.0 libc.so.6 libcollada-dom2.4-dp.so.0 libcrlibm.so.0 libfparser-4.5.so libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_4.0.0) liblapack.so.3 libm.so.6 libode.so.4 libopenrave-core.so.0 libopenrave-core_c.so.0 libopenrave.so.0 libopenrave_c.so.0 libosg.so.130 libosgDB.so.130 libosgFX.so.130 libosgGA.so.130 libosgManipulator.so.130 libosgQt.so.130 libosgText.so.130 libosgViewer.so.130 libpcrecpp.so.0 libpthread.so.0 libqhull.so.7 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.8) libstdc++.so.6(CXXABI_1.3.9) libxml2.so.2 libxml2.so.2(LIBXML2_2.4.30) libxml2.so.2(LIBXML2_2.6.0) libz.so.1 openrave-models rtld(GNU_HASH) Provides -------- python2-openrave: python2-openrave python2-openrave(x86-32) pythonNonedist(openravepy) openrave-octave: openrave-octave openrave-octave(x86-32) openrave-models: openrave-models openrave-doc: openrave-doc openrave-debuginfo: openrave-debuginfo openrave-debuginfo(x86-32) openrave-devel: cmake(openrave) openrave-devel openrave-devel(x86-32) pkgconfig(openrave) pkgconfig(openrave-core) openrave: bundled(convexdecomposition) bundled(ivcon) libopenrave-core.so.0 libopenrave-core_c.so.0 libopenrave.so.0 libopenrave_c.so.0 openrave openrave(x86-32) Unversioned so-files -------------------- openrave: /usr/lib/openrave/plugins/libbasecontrollers.so openrave: /usr/lib/openrave/plugins/libbaserobots.so openrave: /usr/lib/openrave/plugins/libbasesamplers.so openrave: /usr/lib/openrave/plugins/libbasesensors.so openrave: /usr/lib/openrave/plugins/libconfigurationcache.so openrave: /usr/lib/openrave/plugins/libdualmanipulation.so openrave: /usr/lib/openrave/plugins/libgrasper.so openrave: /usr/lib/openrave/plugins/libikfastsolvers.so openrave: /usr/lib/openrave/plugins/liblogging.so openrave: /usr/lib/openrave/plugins/liboderave.so openrave: /usr/lib/openrave/plugins/libpqprave.so openrave: /usr/lib/openrave/plugins/libqtcoinrave.so openrave: /usr/lib/openrave/plugins/libqtosgrave.so openrave: /usr/lib/openrave/plugins/librmanipulation.so openrave: /usr/lib/openrave/plugins/librplanners.so openrave: /usr/lib/openrave/plugins/libtextserver.so python2-openrave: /usr/lib/python2.7/site-packages/openravepy/_openravepy_/convexdecompositionpy.so python2-openrave: /usr/lib/python2.7/site-packages/openravepy/_openravepy_/openravepy_configurationcache.so python2-openrave: /usr/lib/python2.7/site-packages/openravepy/_openravepy_/openravepy_int.so python2-openrave: /usr/lib/python2.7/site-packages/openravepy/_openravepy_/pyANN_int.so Source checksums ---------------- https://github.com/rdiankov/openrave/archive/8bfb8a6a96d5606b663436495983b0605f251f60/openrave-8bfb8a6.tar.gz : CHECKSUM(SHA256) this package : 7c75873d4675692714e68e472a463ceed86cb1955d494f06ed3ea3f440cb1b59 CHECKSUM(SHA256) upstream package : 7c75873d4675692714e68e472a463ceed86cb1955d494f06ed3ea3f440cb1b59 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -b 1338339 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx