https://bugzilla.redhat.com/show_bug.cgi?id=1361288 --- Comment #3 from Till Hofmann <till.hofmann@xxxxxxxxx> --- (In reply to Antonio Trande from comment #2) > (In reply to Till Hofmann from comment #1) > > One thing I noticed: You package the test, but you don't run the test in > > %check. You should run the test in %check but not package it, unless test.py > > is not in fact a test. > > > > Other than that, the package looks good! I'll post a formal review when the > > issue above is fixed. > > test.py needs 'luckydonaldUtils' > (https://github.com/luckydonald/luckydonald-utils/tree/master/ > luckydonaldUtils) to work. > Currently, pytg could be tested manually after installing 'luckydonaldUtils'. I see. So you package test.py so you can test it manually afterwards? I'm still not sure if the test should be in the final package, but I guess that's a minor issue, so it's up to you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx