https://bugzilla.redhat.com/show_bug.cgi?id=1360952 --- Comment #23 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to Frederico Henrique Gonçalves Lima from comment #21) > (In reply to Paulo Andrade from comment #19) > > > I believe you could add cdripper.sh to the package, or to a > > quake2-utils package. > > cdripper.sh already in the package, /usr/share/doc/quake2/examples/ Thanks for noting that. > quake3 do the same as this new package, > have to download free demo or buy the full version. > > but the package don't do this for you, you have to follow the instructions, > like quake3 already on official fedora repo The problem I see are the links. This is a somewhat gray area. Maybe the instruction to run should be something like: $ mkdir quake2-dl $ cd quake2-dl $ wget http://deponie.yamagi.org/quake2/idstuff/q2-314-demo-x86.exe $ unzip q2-314-demo-x86.exe $ sudo cp Install/Data/baseq2/pak0.pak /usr/lib64/games/quake2/baseq2/ or $ mkdir -p ~/.yq2/baseq2 $ cp Install/Data/baseq2/pak0.pak ~/.yq2/baseq2 $ quake2 The instruction for download link could be better instructing to download from ftp://ftp.idsoftware.com/idstuff/quake2/ and instead of having it in %description, have it in a README.fedora %doc file. This is my first time checking these as well, but I suggest checking the packages that use the quake3 engine. They use wrappers, and some other checks, for example /usr/share/opengl-games-utils/opengl-game-functions.sh and checkDriOK, that would by default not start if there is no 3D acceleration. Some of that may be somewhat outdated. openarena distributes its free data files. worldofpadman and quake3-demo uses autodownloader. Maybe you could use a similar approach, having a quake2 wrapper, and use autodownloader to download and extract to $HOME/.yq2/baseq2, this would as well ensure the user knows what is being done, and agrees to any licenses. What you think about using autodownloader? Please check quake3-demo and worldofpadman packages, and how those packages use a wrapper shell, and the related .autodlrc file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx