https://bugzilla.redhat.com/show_bug.cgi?id=1353000 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- BuildRequires: git-core You probably want to replace %{python3_sitelib}/gns3_server-1.5.0-py3.5.egg-info/ → %{python3_sitelib}/gns3_server-%{version}-py*.egg-info/ Please consider also building the docs. They seem a bit bare-bones, so maybe they shouldn't be packages. If you do, the following should be enough: Add BR: python-sphinx, and 'make -C docs html' in %build, and docs/_build/html in %files. The docs are >2MiB, so you'd probably need to create a -doc subpackage. + package name is OK + latest version + license is acceptable for Fedora (GPLv3) + license is specified correctly + systemd file is provided, proper scriptlets are used + provides/requires look sane + package builds and installs OK (apart from the missing BR) Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx