[Bug 1353000] Review Request: gns3-server - Graphical Network Simulator 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1353000

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
There is no reason for the service subpackage, afaict. It only contains the
service file so it's tiny, and has no significant dependencies.

gn3server package installs module "utils" as a standalone package. This cannot
be. It must be fixed to move "utils" into the dns3server namespace. This seems
to be an upstream error, but it's likely to cause problems for other packages.

The mode of gns3 dir should also be put in %files:
%dir %attr(2755,gns3,gns3) %{_sharedstatedir}/gns3

Please split the Requires into one-per-line.

Typo: ressources

Can you explain the comment about busybox "TODO: fix the code to use system's
busybox"?

Type=simple is bad. It means that it's not possible for other services to know
when gns3server has started. But that's an upstream issue, not a packaging
error. Something that should be changed in the long run.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]