https://bugzilla.redhat.com/show_bug.cgi?id=1356587 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Everything looks ok (from packaging PoV), no Blockers Only one clarification: IIUC, _autoload.php is designed for compatibility with non-namespaced version 1 of the library. So application using this library probably don't need it. Instead of including _autoload.php (without NS) from autoload.php (SAML2 NS) shouldn't it be better to do the opposite ? application using v1 will include _autoload.php, thus will get a working autoloader without NS (and SAML2 NS required by class alias). application using v2 will include autoload.php, this will get a working autoloader "only" for SAML2 NS. What do you think ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx