https://bugzilla.redhat.com/show_bug.cgi?id=1359473 --- Comment #3 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- Thanks for taking a look! Updated source and spec, also some comments below: Spec URL: https://tc01.fedorapeople.org/dwarffortress/legendsbrowser.spec SRPM URL: https://tc01.fedorapeople.org/dwarffortress/legendsbrowser-1.0.12-2.fc24.src.rpm > require are generate during the build My bad; for some reason, I assumed this was not the case. (This is my first Java package). > %dir %{_javadir}/%{name} > prevent duplicate file Is this no longer necessary? I was following this possibly obsolete document on Java packaging (https://fedorahosted.org/released/javapackages/doc/#maven) and it had a %dir file include of that form. Anyway, I commented it out in the updated spec. > Add for each single JS library or fonts : Provides: bundled(foo) =fooversion Whoops. Added this information, and updated license accordingly ("and BSD and CC-BY"). > Seem also which most of the java/source code are without license headers. > Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers I actually sort of have already have done so, although I did not ask for licensing headers-- prior to me filing https://github.com/robertjanetzko/LegendsBrowser/issues/9, upstream was not even distributing a LICENSE file or making any other reference to the license of the software that I could find (!). I can follow up though and verify that *all* the code that isn't third-party JS/CSS/fonts is indeed MIT if this is not sufficient. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx