Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: prcsys - Parallel rc with LSB dependency resolver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245720 karsten@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |karsten@xxxxxxxxxx ------- Additional Comments From karsten@xxxxxxxxxx 2007-07-03 06:11 EST ------- I've followed http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and list 'not OK' issues here: - description NAK Normal users won't know what all this is about, please add some text here - compiler flags NAK All packages (even such small ones) should use %{?_smp_mflags} . If this breaks anything, a short note should be added as a comment in the spec file - macros OK, but you're mixing p.e. %{buildroot} and $RPM_BUILD_ROOT, try to stay with one style /var can be written as %{_localstatedir} SHOULD: - source package doesn't include license text as a separate file from upstream, please query upstream about it -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review