Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qwt - Qt Widgets for Technical Applications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240180 ------- Additional Comments From bugs.michael@xxxxxxx 2007-07-03 05:25 EST ------- A brief look at the spec as a start: Run rpmlint on the source and binary rpms. > %package devel > Summary: Development and doc files for {%name} Typo in the summary. > Beside a 2D plot widget it provides scales, sliders, dials, compasses, Besides... > %description devel > Cotains the development files. Contains... > %prep > %setup -q -n %{name}-%{version} -n %{name}-%{version} is the default > %install > make install "rm -rf $RPM_BUILD_ROOT" must be the first command in the %install section. > %files %defattr definition is missing > %files devel same here > %{_includedir}/%{name}/* directory %{_includedir}/%{name} is not included > %changelog > * Mon Jun 11 2007 Frank Büttner <frank-buettner@xxxxxxx> - 5.0.2-1%{?dist} Don't use %dist in %changelog, as it alters history whenever %dist changes. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review