https://bugzilla.redhat.com/show_bug.cgi?id=1360274 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok macros: ok scriptlets: ok sources: ok fa473ab9175483dd82aa4d27b9682715 qtvirtualkeyboard-opensource-src-5.7.0.tar.xz licensing: ok dependencies: mostly ok 1. SHOULD: I see: %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} but no matching BuildRequires: qt5-qtbase-private-devel (which is what we currently use to easily track these hard versioned dependencies). Please add that Otherwise, relatively simple package, matches conventions and style of other existing qt5 packages. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx