https://bugzilla.redhat.com/show_bug.cgi?id=1358939 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 91c2b7d8e707a4cf68cf17735eb845bce9e32fc0c59e5f7bd1d94c1874e002b7). Ok. Summary verified from lib/Dancer2/Plugin/REST.pm. Ok. Description is Ok. License verified from README.mkdn, LICENSE, lib/Dancer2/Plugin/REST.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Constrain `perl(Dancer2)' dependency with a version (META.json:33). All tests pass. Ok. $ rpmlint perl-Dancer2-Plugin-REST.spec ../SRPMS/perl-Dancer2-Plugin-REST-0.27-1.fc25.src.rpm ../RPMS/noarch/perl-Dancer2-Plugin-REST-0.27-1.fc25.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lp -v ../RPMS/noarch/perl-Dancer2-Plugin-REST-0.27-1.fc25.noarch.rpm drwxr-xr-x 2 root root 0 Jul 26 13:45 /usr/share/doc/perl-Dancer2-Plugin-REST -rw-r--r-- 1 root root 2833 Dec 29 2015 /usr/share/doc/perl-Dancer2-Plugin-REST/Changes -rw-r--r-- 1 root root 3122 Dec 29 2015 /usr/share/doc/perl-Dancer2-Plugin-REST/README -rw-r--r-- 1 root root 3506 Dec 29 2015 /usr/share/doc/perl-Dancer2-Plugin-REST/README.mkdn drwxr-xr-x 2 root root 0 Jul 26 13:45 /usr/share/licenses/perl-Dancer2-Plugin-REST -rw-r--r-- 1 root root 18355 Dec 29 2015 /usr/share/licenses/perl-Dancer2-Plugin-REST/LICENSE -rw-r--r-- 1 root root 2613 Jul 26 13:44 /usr/share/man/man3/Dancer2::Plugin::REST.3pm.gz drwxr-xr-x 2 root root 0 Jul 26 13:44 /usr/share/perl5/vendor_perl/Dancer2 drwxr-xr-x 2 root root 0 Jul 26 13:44 /usr/share/perl5/vendor_perl/Dancer2/Plugin -rw-r--r-- 1 root root 8039 Dec 29 2015 /usr/share/perl5/vendor_perl/Dancer2/Plugin/REST.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Dancer2-Plugin-REST-0.27-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(Class::Load) 1 perl(Dancer2::Plugin) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Dancer2-Plugin-REST-0.27-1.fc25.noarch.rpm | sort -f | uniq -c 1 perl(Dancer2::Plugin::REST) = 0.27 1 perl-Dancer2-Plugin-REST = 0.27-1.fc25 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Dancer2-Plugin-REST-0.27-1.fc25.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15023162). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx