Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Test-Output - Utilities to test STDOUT and STDERR messages https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246537 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-07-03 02:36 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url dcf67296e04a41a9f73f70c10fe5f825 Test-Output-0.10.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00.load............# Testing Test::Output 0.10 ok t/combined_is........ok t/combined_isnt......ok t/combined_like......ok t/combined_unlike....ok t/output_is..........ok t/output_isnt........ok t/output_like........ok t/output_unlike......ok t/pod-coverage.......ok t/pod................ok t/stderr_is..........ok t/stderr_isnt........ok t/stderr_like........ok t/stderr_unlike......ok t/stdout_is..........ok t/stdout_isnt........ok t/stdout_like........ok t/stdout_unlike......ok All tests successful. Files=19, Tests=1209, 2 wallclock secs ( 1.46 cusr + 0.22 csys = 1.68 CPU) + Provides: perl(Test::Output) = 0.10 perl(Test::Output::Tie) + Requires: perl(:MODULE_COMPAT_5.8.8) perl(Sub::Exporter) perl(Sub::Exporter) perl(Test::Builder) perl(Test::Output::Tie) perl(Test::Tester) >= 0.103 perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review