https://bugzilla.redhat.com/show_bug.cgi?id=1356907 Igor Gnatenko <ignatenko@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #6 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- * License file FiraSans-LICENSE.txt is not marked as %license * Package has .a files * %doc %{_docdir}/%{name}/html/ -> nothing actually owns %{_docdir}/%{name} for -doc subpackage * %define bootstrap_base https://static.rust-lang.org/dist/%{bootstrap_date}/rustc-%{bootstrap_channel} use %global * BuildRequires: python -> is it really needed like python? not python2 or python3? * -doc subpackage must be noarch * is it possible to move all lib*.so into for example, %{_libdir}/rust/? Bundled libs, add to License tag and include licenses to %license: * libbacktrace is BSD * hoedown is ISC * I think "or" should be replaced with "and" in License or rust is licensed on one or second license? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx