https://bugzilla.redhat.com/show_bug.cgi?id=1352175 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Sandro Mani from comment #1) > Approved, only two remarks: > > - You could use %make_build instead of make %{?_smp_mflags} Is that a new macro? I don't recall seeing it before. > - Upstream could be encouraged to add license headers to the source files: > src/floattypes.h: UNKNOWN > src/mpc.c: UNKNOWN > src/float.c: UNKNOWN > src/mpfr.c: UNKNOWN > src/mpd.c: UNKNOWN > src/mpfi.c: UNKNOWN Okay. I am already in contact with upstream on a couple of other minor issues, so I will mention this. Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx