[Bug 1358959] Review Request: nsntrace - Perform network trace of a program using network namespaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1358959



--- Comment #3 from Jonas Danielsson <jonas@xxxxxxxxxxxxxxxxx> ---
(In reply to Igor Gnatenko from comment #2)
> Suggest you to do something like this:
> --- nsntrace.spec.orig	2016-07-22 08:42:06.024075138 +0200
> +++ nsntrace.spec	2016-07-22 08:49:33.931017162 +0200
> @@ -4,19 +4,17 @@
>  Summary:        Perform network trace of a program by using network
> namespaces
>  
>  License:        GPLv2+
> -URL:            https://github.com/jonasdn/nsntrace/
> -Source0:       
> https://github.com/jonasdn/nsntrace/releases/download/v1/nsntrace-1.tar.gz
> +URL:            https://github.com/jonasdn/nsntrace
> +Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
>  
> -# Committed upstream as 67b1715f0c01b1cd97c9e9eab1d4d5586ec8bfed
> -Patch1:         nsntrace-xsltproc-nonet.patch
> +Patch1:         %{url}/commit/67b1715f0c01b1cd97c9e9eab1d4d5586ec8bfed.patch
>  
> -BuildRequires:  automake
> -BuildRequires:  autoconf
> +BuildRequires:  gcc
> +BuildRequires:  automake autoconf libtool
>  BuildRequires:  libpcap-devel
> -BuildRequires:  libnl3-devel
> -BuildRequires:  iptables
> -BuildRequires:  libxslt
> -BuildRequires:  docbook-style-xsl
> +BuildRequires:  pkgconfig(libnl-route-3.0)
> +BuildRequires:  libxslt docbook-style-xsl
> +BuildRequires:  /usr/sbin/iptables
>  
>  %description
>  The nsntrace program uses Linux network namespaces to perform network traces
> @@ -24,25 +22,20 @@
>  analyzed by for instance Wireshark.
>  
>  %prep
> -%setup -q -n %{name}-%{version}
> -
> -%patch1 -p0
> +%autosetup -p1
>  
>  %build
> +autoreconf -vfi
>  %configure
> -make %{?_smp_flags}
>  %make_build
>  
> -
>  %install
> -rm -rf $RPM_BUILD_ROOT
>  %make_install
>  
>  %files
> -%{_bindir}/*
> -%{_mandir}/man1/*
>  %license LICENSE
> -
> +%{_bindir}/%{name}
> +%{_mandir}/man1/%{name}.1*
>  
>  %changelog
>  * Thu Jul 21 2016 jonas <jonas@xxxxxxxxxxxxxxxxx> - 1-1

Thank you so much for the review! Really appreciate it!
I will run this through mock and koji when I get home, and update the
spec-file.

Jonas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]