[Bug 1339302] Review Request: libinvm-cli - Framework library supporting common Intel NVM storage CLI applications.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1339302



--- Comment #8 from Dan Williams <dan.j.williams@xxxxxxxxx> ---
(In reply to Namratha Kothapalli from comment #7)
> Here's the result of a fedora-review run with the rest of the template
> filled out: 
[..]

Looks good, just need to drop "-lm" out of the linker line to fix this report:

> libinvm-cli.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libinvm-cli.so.1.0.0 /lib64/libm.so.6

i.e.:

Index: libinvm-cli-1.0.0.1095/src/makefile
===================================================================
--- libinvm-cli-1.0.0.1095.orig/src/makefile
+++ libinvm-cli-1.0.0.1095/src/makefile
@@ -75,7 +75,7 @@ ifdef BUILD_WINDOWS
        LIBS += -lws2_32 -lmswsock -ladvapi32 -lversion -lGdi32 -lShlwapi \
                        -L$(BUILD_DIR) -lssp -lpthread
 else
-       LIBS += -lpthread -ldl -lm
+       LIBS += -lpthread -ldl
 endif

 # ---- RECIPES
------------------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]