[Bug 1346038] Review Request: python-blivet1 - python2/ blivet-1.x compatibility package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1346038

David Lehman <dlehman@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dlehman@xxxxxxxxx |
                   |m)                          |



--- Comment #7 from David Lehman <dlehman@xxxxxxxxxx> ---
(In reply to Yaniv Bronhaim from comment #6)
> The url does matter for rpmlint and reasonable to have it reachable - you
> can take care of making Source0 reachable. Users might want to get the
> actual source tarball, and some tools try to download it as well.

They can try to download it, but they will not be able to build an rpm with it.
I can adjust the url, but nobody will be building rpms from that.

> 
> I assume you have a reason for the naming, but it doesn't mean the errors
> are wrong. please ignore them - understand why you are trying to reach
> /usr/share/locale/en-*/LC_MESSAGES/blivet1.mo. 

The errors are not valid in this case, as I explained. The package cannot use
/usr/share/locale/en-*/LC_MESSAGES/blivet.mo as that is already in use by
python3-blivet-2.x in rawhide.

> 
> Correcting the change-log prints is quite easy and reasonable to ask as well.

The version error is because I gave you a scratch build with a timestamp in the
version. There is nothing to fix, unless the version I upload must exactly
match what I will import into dist-git.

> 
> You need to fix those errors.. its fedora guidelines, not mine

I was told that rpmlint errors do not necessarily block the acceptance of a
package, especially when there is a reasonable explanation for the
warnings/errors.


I will upload a new version with a reachable (but unusable) Source0 and an
easier to parse version. The translations will not be changed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]