[Bug 1358357] Review Request: python-pygpgme - Python module for working with OpenPGP messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1358357



--- Comment #2 from Jon Ciesla <limburgher@xxxxxxxxx> ---
- rpmlint checks return:

python-pygpgme.src: W: spelling-error %description -l en_US decrypt -> decry
pt, decry-pt, decry
The value of this tag appears to be misspelled. Please double-check.

Ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
! package compiles on devel (x86)

mock build succeeds on f24 but fails on rawhide:

test_edit_ownertrust (tests.test_editkey.EditKeyTestCase) ... ERROR
test_edit_quit (tests.test_editkey.EditKeyTestCase) ... ERROR
test_edit_sign (tests.test_editkey.EditKeyTestCase) ... ERROR
test_invalid_parameters (tests.test_genkey.GenerateKeyTestCase) ... ok

======================================================================
ERROR: test_edit_ownertrust (tests.test_editkey.EditKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pygpgme-0.3/tests/test_editkey.py", line 63, in
test_edit_ownertrust
    gpgme.editutil.edit_trust(ctx, key, trust)
  File
"/builddir/build/BUILDROOT/python-pygpgme-0.3-17.fc25.i386/usr/lib/python2.7/site-packages/gpgme/editutil.py",
line 75, in wrapper
    ctx.edit(key, edit_callback, output)
GpgmeError: (32, 1, u'General error')

======================================================================
ERROR: test_edit_quit (tests.test_editkey.EditKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pygpgme-0.3/tests/test_editkey.py", line 48, in
test_edit_quit
    ctx.edit(key, self.edit_quit_cb, output)
GpgmeError: (0, 32779, u'Bad file descriptor')

======================================================================
ERROR: test_edit_sign (tests.test_editkey.EditKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pygpgme-0.3/tests/test_editkey.py", line 80, in
test_edit_sign
    gpgme.editutil.edit_sign(ctx, key, check=0)
  File
"/builddir/build/BUILDROOT/python-pygpgme-0.3-17.fc25.i386/usr/lib/python2.7/site-packages/gpgme/editutil.py",
line 75, in wrapper
    ctx.edit(key, edit_callback, output)
GpgmeError: (32, 1, u'General error')

----------------------------------------------------------------------
Ran 55 tests in 49.505s

FAILED (errors=3)


- no missing BR
! no unnecessary BR

Explicit gcc BR is not needed, remove.

- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


So it's just the tests in rawhide, and the BR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]