https://bugzilla.redhat.com/show_bug.cgi?id=1238385 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |projects.rg@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |projects.rg@xxxxxxxx --- Comment #1 from Raphael Groner <projects.rg@xxxxxxxx> --- I take this. Review swap with bug #1357064, as discussed. But don't expect anything in the next days. Could do the official review later. Some general hints found in prior of the official review run: > %doc COPYING Change to: %license COPYING > URL: https://github.com/manisandro/qtspell > Source0: https://github.com/manisandro/qtspell/releases/download/%{version}/%{pkgname}-%{version}.tar.xz Could be simplified: URL: https://github.com/manisandro/%{pkgname} Source0: %{url}/releases/download/%{version}/%{pkgname}-%{version}.tar.xz Although, our policy recommends to use an archive URL instead. I've never seen such with release so far. But maybe you prefer to use the xz tarball over gz. https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags Qt4 development is stalled since some monthes, in favor of Qt5. We should generally think about still packaging for Qt4. Maybe skip the qt4 subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx