[Bug 1358248] Review Request: python-http-client - HTTP REST client, simplified for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1358248

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |ignatenko@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ignatenko@xxxxxxxxxx



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> %global sum HTTP REST client, simplified for Python
put to Summary tag and reuse further as %{summary}

> %autosetup -n %{name}-%{version}
jsut %autosetup

> %{python3_sitelib}/python_http_client*
too relax (actually you have 2 same lines, with glob and without). it's always
better to be more precised

* No pythonX-setuptools BR, guess it's missing
* Reuse %{url} in Source tag
* add "-v" to py.test invocation (useful when some test fails)
* do %global _description and reuse from descriptions. Also add "Python X
version." for each subpackage to easily identify without name where it belongs
to.
* Move BuildRequires under subpackages for better look&feel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]