[Bug 1356552] Review Request: php-onelogin-php-saml - SAML support for PHP softwares

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1356552

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #8 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
>From PHP Guidelines: "PHP extensions must have a Requires on all of the
dependent extensions" 

>From composer.json

    "require": {
        "php": ">=5.3.2",
        "ext-openssl": "*",
        "ext-dom": "*",
        "ext-mcrypt": "*"
    },

So please add

Requires: php-openssl
Requires: php-dom

>From phpcompatinfo analysis (attachement), also add

Requires: php-date
Requires: php-filter
Requires: php-hash
Requires: php-libxml
Requires: php-pcre
Requires: php-session
Requires: php-zlib

Suggests: php-gettext


>From PHP Guidelines: "A PSR-0 [1] compliant library would put its PHP files in
/usr/share/php/<Vendor Name> "

As provided classes are OneLogin_Saml_* and OneLogin_Saml2_* should be
installed in (PSR-0 compliant tree):
/usr/share/php/OneLogin/Saml
/usr/share/php/OneLogin/Saml2

(autoloader in Saml or/and Saml2 directory)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]