https://bugzilla.redhat.com/show_bug.cgi?id=1050744 --- Comment #43 from nucleo <alekcejk@xxxxxxxxxxxxxx> --- (In reply to Tom "spot" Callaway from comment #41) > With the patch in Comment 40 applied, this package builds cleanly on Fedora > 24 (the patch fixes an obvious typo in a comparison that wasn't caught by > earlier gcc revisions). > > All the items noted in Chris's previous review are resolved in 1.4.2-1, so > I'm approving this package (please be sure to apply that patch before > committing). Thanks for the patch but it builds fine only in F24 and fails in Rawhide: belle_sip_utils.c: In function 'belle_sip_parse_directory': belle_sip_utils.c:1241:2: error: 'readdir_r' is deprecated [-Werror=deprecated-declarations] res = readdir_r(dir, ent, &result); ^~~ In file included from belle_sip_utils.c:31:0: /usr/include/dirent.h:183:12: note: declared here extern int readdir_r (DIR *__restrict __dirp, ^~~~~~~~~ belle_sip_utils.c:1249:3: error: 'readdir_r' is deprecated [-Werror=deprecated-declarations] res = readdir_r(dir, ent, &result); ^~~ In file included from belle_sip_utils.c:31:0: /usr/include/dirent.h:183:12: note: declared here extern int readdir_r (DIR *__restrict __dirp, ^~~~~~~~~ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx