[Bug 1357566] Review Request: python-stdnum - Python module to handle standardized numbers and codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1357566

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dan@xxxxxxxx
              Flags|                            |needinfo?(dan@xxxxxxxx)



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
1. %global with_check 0

Can you please use bcond here? It's more easy to operate with.
http://www.rpm.org/wiki/PackagerDocs/ConditionalBuilds

2. BuildRequires:  python-sphinx

Why is that so?

Formal review will follow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]